[Twisted-Python] ReverseProxy doesn't send X-Forwarded-For header

[Lance Kurisaki]

I understand your reasons and agree. My only reservation is that if
someone wants to send the header, it's not immediately obvious (wasn't
to me, anyway) what the proper line of code is and where it should go.
It took me a while to figure it out.

Perhaps if we make it dependent on an instance attribute, such as
"sendXForwardedFor", which is by default set to 0?

I have no problem if you decide to leave it out entirely, though...

					Lance

-----Original Message-----
From: Moshe Zadka [mailto:m at moshez.org] 
Sent: Monday, June 02, 2003 9:48 PM
To: twisted-python at twistedmatrix.com
Subject: Re: [Twisted-Python] ReverseProxy doesn't send X-Forwarded-For
header


On Mon, 2 Jun 2003, Itamar Shtull-Trauring <itamar at itamarst.org> wrote:

> Done. Thanks!

I have reverted this patch, for the following reasons:

1. It removes functionality: there is no way for subclasses to avoid
sending
   this header, while it is easy, the way the code is now, for a
subclass
   to add this header if it so wishes.

2. It divulges private information (the client's IP) to possibly hostile
   parties.

If you really want this, just do it in a custom subclass.
 
-- 
Moshe Zadka -- http://moshez.org/
Buffy: I don't like you hanging out with someone that... short.
Riley: Yeah, a lot of young people nowadays are experimenting with
shortness.
Agile Programming Language -- http://www.python.org/

_______________________________________________
Twisted-Python mailing list
Twisted-Python at twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python