[Twisted-Python] HTTP client should be more tolerant?

Markus Stenberg fingon at iki.fi
Sun Feb 6 01:02:27 MST 2005


Tommi Virtanen <tv at twistedmatrix.com> writes:
> Markus Stenberg wrote:
>> Changes required? web/http.py:
>> @@ -314,6 +314,7 @@
>>      length = None
>>      firstLine = 1
>>      __buffer = ''
>> +    delimiter = '\n'
>>       def sendCommand(self, command, path):
>>          self.transport.write('%s %s HTTP/1.0\r\n' % (command, path))
> That affects self.sendLine() too, causing your modified version to
> potentially send LF-only lines. Not what you wanted.

At least in 1.3 the HTTP stuff doesn't use sendLine for some ineffable
reason. Probably not in the old stuff in svn either, but don't have checked
out copy at home ;) wonder why sendCommand/Header, endHeaders are
implemented using transport.write..

-Markus





More information about the Twisted-Python mailing list