[Twisted-Python] svn-reorg blocking

[glyph at divmod.com]

On Wed, 26 Oct 2005 13:36:35 +1100, Christopher Armstrong <radeex at gmail.com> wrote:

>I refer you to James' post. I'm fairly happy with your solution
>(although I still think that structurally it is less pleasant that
>having the implementation modules be in a package), but I'll let you
>and James debate it.

I don't like 'serialport' being a package, but that is a totally separate issue.  If James' changes actually fix the problem, let's just go with that and be done with it; if we make serialport not be a package later, then the need for the extra attribute will go away.

>On 10/26/05, James Y Knight wrote <foom at fuhm.net> wrote:

>The way I see it is that you put a horrible hack in trial to work
>around a problem that wouldn't happen if the code actually followed
>Twisted's coding convention.

In James' defense, Twisted's coding standard actually says what serialport is doing is OK.  The portion of the standard that says this is my work, and I think the coding standard should be changed, because this is an awful hack, but one thing that can't be said about it is that it isn't officially endorsed :).

I tend to agree with your general sentiment but I don't think that this issue is important enough to hold up the re-org.  James has implemented a solution.  Let's just use it.