[Twisted-Python] some bugs(?)

[Antony Kummel]

--- Jonathan Lange <jonathan.lange at gmail.com> wrote:

> On 05/09/05, Antony Kummel <antonykummel at yahoo.com>
> wrote:
> > Hi,
> > 
> > I encountered what seem to be some bugs:
> > 
> > 1. In twisted/scripts/trial.py, line 276: the
> module's
> > contents are not executed if the lines are
> terminated
> > with "\r\n". I suggest using "r" instead of "rb"
> when
> > reading the file. Additionally, I would compile()
> the
> > source before executing it in order to associate
> it
> > with its filename. This will make debugging (at
> least
> > with winpdb) much easier (currently the filename
> is
> > "<string>", which prevents winpdb from finding the
> > source).
> > 
> 
> Hi Antony,
> 
> I've committed a fix for the first bug, as well as a
> couple of unit
> tests to avoid it happening again.  I'd appreciate
> it if you could
> confirm that this indeed fixes your problem.
> 

It does, thanks.

Antony Kummel


	
		
______________________________________________________
Click here to donate to the Hurricane Katrina relief effort.
http://store.yahoo.com/redcross-donate3/