[Twisted-Python] Twisted 10.1.0 release status update

[Thomas Hervé]

Le dimanche 04 juillet 2010 à 10:05 +0100, Jonathan Lange a écrit :
> On Sat, Jul 3, 2010 at 9:43 PM, Thomas Hervé <therve at free.fr> wrote:
> ...
> >
> > The build step is in the master on cube. I think I've fixed it, sorry
> > for the trouble.
> 
> Thanks. It looks like they're working now.
> 
> What was the problem? If something like this happened again, is there
> anything we can do other than ask for help and then wait?

The problem was in the msi builder class in the buildbot master. The
specific files holding those objects
is /srv/bb-master/BuildBot/master/twisted_factories.py

This is the interesting part:


class TwistedBdistMsiFactory(TwistedBaseFactory):
    treeStableTimer = 5*60

    uploadBase = 'public_html/builds/'
    def __init__(self, source, uncleanWarnings, platform, pyVersion):
        python = self.python(pyVersion)
        TwistedBaseFactory.__init__(self, python, source,
           uncleanWarnings)
        self.addStep(
            LearnVersion, python=python, package='twisted', 
            workdir='Twisted')


The problem was that the step used to specify "source" as workdir,
instead of "Twisted". The "source" directory probably doesn't even
exist, so it didn't get the version from the correct place. It got the
wrong value because this step was wrongly copied from
PyOpenSSLBuildFactoryBase class.

Once fixed, a "make restart-master" in /srv/bb-master/BuildBot/ takes
the changed file into account.

Hope this helps,

-- 
Thomas