[Twisted-web] Re: [PATCH] nevow.static.File directory listing

[Lee Harr]

>> >> I was getting an infinitely recursive redirect
>> >
>> >
>> > Actually, this patch (to nevow.static.File) will also
>> > take care of the redirect:
>> >
>> >
>> >
>> > 274c274,281
>> > <             return self.redirect(request)
>> > ---
>> >
>> >>             if not request.uri.endswith('/'):
>> >>                 self.redirect(request)
>>
>>You want to return the self.redirect(request). Otherwise the
>>DirectoryLister will still get rendered to the body of the HTTP result,
>>to no effect.
>
>It should probably also reuse the directoryListing() method, making the
>change:
>
>          if self.fp.isdir():
>-            return self.redirect(request)
>+            if not request.uri.endswith('/'):
>+                return self.redirect(request)
>+            return self.directoryListing()
>


This one works for me.

Without the check, it goes in to a loop and never returns anything.

_________________________________________________________________
Add photos to your messages with MSN 8. Get 2 months FREE*. 
http://join.msn.com/?page=features/featuredemail