[Twisted-Python] DeferredList.addDeferred behaviour

[Christopher Armstrong]

Andrew Bennetts wrote:

> On Wed, Feb 18, 2004 at 09:37:53PM -0300, RITA Y/O RODRIGO DIAZ Y/O BENENSON wrote:

>>The workaround it to first create the list of deferred instance and then
>>instanciate with it the DeferredList. But what sense does have the
>>addDeferred method then ? I this behaviour what is supposed to be ?
> 
> 
> It's not clear to me what the right behaviour here is -- if a DeferredList
> has some number of Deferreds that have all been called, then of course the
> DeferredList should be marked as called, too.  But if you then add an
> uncalled Deferred to it, that sounds like a bug.  

Similar to d.result, IMO, d.called is an "invite-only attribute", in the 
words of Glyph. If you want to touch it, don't whine about its 
semantics. :-)

> Can anyone offer reasons why addDeferred should stay?  Donovan -- CVS says
> you added it, can you remember why?  Is anyone using it?

And addDeferred looks like it should really be _addDeferred.

-- 
  Twisted | Christopher Armstrong: International Man of Twistery
   Radix  |          Release Manager,  Twisted Project
---------+           http://radix.twistedmatrix.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
URL: </pipermail/twisted-python/attachments/20040218/361605c3/attachment.sig>