[Twisted-Python] HTTPClient handling LF only servers

[exarkun at twistedmatrix.com]

On 07:23 pm, kevin.horn at gmail.com wrote:
>On Tue, Jan 25, 2011 at 11:54 AM, Jason J. W. Williams <
>jasonjwwilliams at gmail.com> wrote:
>>Hi Y'all,
>Howdy, Jason!
>>Certain servers (notably Hacker News) break HTTPClient because they 
>>use LF
>>instead of CRLF to terminate header lines. I've uploaded a patch with 
>>tests
>>to ticket 4814 (merged into ticket 2842).
>>
>>I'd appreciate a review and some discussion about integrating it.
>>
>>-J
>I'm not really in a position to do a review right now, but since:
>
>1) 4814 is effectively a duplicate of 2842
>2) 4814 has a clear problem decription
>3) 4814 has a patch
>4) 2842 is old, and confusing
>
>Can we go ahead and close 2842 in favor of 4814?  We have too many old
>tickets floating around...

#4814 is already closed.  If the #2842 description is confusing, then 
feel free to update it to be more clear. :)

We don't close old tickets as duplicates of new tickets, though.  That 
doesn't make sense, and it's annoying to the original reporter/cc list 
as well.
>
>(To be clear, I'm not asking Jason to close this ticket...I'm asking 
>for the
>list's opinion)
>
>Also 3833 is at least similar, if not another duplicate.  It would be 
>nice
>if it could be worked on and/or closed along with this issue.

Similar, certainly.  But it's for the other HTTP client implementation. 
There won't be any code in common in the resolution.

I certainly agree that if it's worth fixing for one it's worth fixing 
for the other, though, and I hope someone will put #3833 up for review 
soon. :)

Jean-Paul