[Twisted-Python] t.w.client.Agent exceptions

[exarkun at twistedmatrix.com]

On 5 Mar, 10:49 pm, p.mayers at imperial.ac.uk wrote:
>On 05/03/2014 22:08, Glyph Lefkowitz wrote:
>>You're right; this is a bug in Agent.
>>
>><http://twistedmatrix.com/trac/ticket/5310>
>
>And it must be said, really quite an infuriating one ;o)
>>
>>For right now, yes, you're going to have to import some crappy private
>>APIs.  Any chance I could convince you to submit some fixes to that
>>ticket so we won't have to do that in the future? :-)
>
>I'll have a look tomorrow; though it seems like testing that would be 
>tricky, and pointers to existing examples of how to test that Failure- 
>with- traceback is being raised?
>
>Do we know what the rationale for _WrapperException was? The only place 
>it's used, it wraps a single exception, which is "singularly" pointless 
>(ha ha marvel at my comedy).

I think you overlooked some of its uses.  For example, ResponseFailed is 
a _WrapperException subclass and it is constructed with two failures in 
HTTP11ClientProtocol.connectionLost.

Jean-Paul