[Twisted-Python] Fix link on trac for logging in

Glyph glyph at twistedmatrix.com
Sat Aug 18 13:17:02 MDT 2018


The twisted trac source code is here: https://github.com/twisted-infra/twisted-trac-source <https://github.com/twisted-infra/twisted-trac-source> 

I think the relevant bit of code is https://github.com/twisted-infra/twisted-trac-source/blob/6b7b4156a50c05f28437eba506177a9f3bcccac6/trac/web/main.py#L481 <https://github.com/twisted-infra/twisted-trac-source/blob/6b7b4156a50c05f28437eba506177a9f3bcccac6/trac/web/main.py#L481> here, but I'm not quite sure how to change it.

If you can make a PR we can probably get it deployed though, this is definitely an annoying bug.

(Alternately, maybe just make /trac/login a redirect in the web server?)

-g

> On Aug 16, 2018, at 11:43 PM, Craig Rodrigues <rodrigc at crodrigues.org> wrote:
> 
> Is there someone with access to the twistedmatrix Trac source code
> who can fix the text at the place where it says You are not logged in aftr clicking on
> https://twistedmatrix.com/trac/newticket <https://twistedmatrix.com/trac/newticket> ?
> 
> --
> Craig
> 
> On Thu, Jun 14, 2018 at 11:21 AM Craig Rodrigues <rodrigc at crodrigues.org <mailto:rodrigc at crodrigues.org>> wrote:
> Hi,
> 
> If a user clicks on this link:
> https://twistedmatrix.com/trac/newticket <https://twistedmatrix.com/trac/newticket>
> 
> They see this text:
> 
> You are currently not logged in. You may want to do so <https://twistedmatrix.com/trac/login> now. 
> 
> The link on "do so" is wrong.  
> 
> Can someone fix that link to point to the Github login link?
> 
> Ideally, this link:
> https://twistedmatrix.com/trac/login <https://twistedmatrix.com/trac/login>
> 
> should redirect to:
> https://twistedmatrix.com/trac/github/login <https://twistedmatrix.com/trac/github/login>
> 
> Because there seem to be various paths that users are hitting the
> first link and then getting confused when they can't log into Trac.
> --
> Craig
> _______________________________________________
> Twisted-Python mailing list
> Twisted-Python at twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20180818/66f3ea1e/attachment-0002.html>


More information about the Twisted-Python mailing list