[Twisted-Python] Code review comment for http.py

Scott, Barry barry.scott at forcepoint.com
Fri Oct 4 05:26:20 MDT 2019


I see that there are duplicate lines in http.py in
_GenericHTTPChannelProtocol.dataReceived()

Notice that around line 2960 two calls to setTimeout().

                networkProducer.unregisterProducer()

                # Cancel the old channel's timeout.
                self._channel.setTimeout(None)

                # Cancel the old channel's timeout.
                self._channel.setTimeout(None)

                transport = self._channel.transport


Barry





More information about the Twisted-Python mailing list