Hi,<div><br><div class="gmail_quote">On Mon, Sep 12, 2011 at 4:38 PM, Tobias Oberstein <span dir="ltr"><<a href="mailto:tobias.oberstein@tavendo.de">tobias.oberstein@tavendo.de</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
No, it's not. From a cursory look at the code (didn't knew it existed):<br></blockquote><div><br></div><div>That repo on Github is based on a Twisted branch that was nearly ready for inclusion into Twisted. This was back in the day when the websocket protocol seemed on the verge of stabilizing. Obviously this wasn't the case. I came along and added cross version support for the next iteration of the protocol which was then newly supported in Chrome. Then there came the discovery of a cache poising security flaw that was eventually addressed in the latest iteration of the websocket protocol. I haven't yet had time to incorporate it, though I believe there is an open pull request for its support (thanks, to whoever that was).</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Outdated WS protocol, probably wasnt complete at any time, based on the Site class.<br></blockquote><div><br></div><div>Depends on what you consider to be "complete" I guess. It had working examples and stayed close to the reference Twisted implementation, which was in the last stages of its code review.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Autobahn WS has complete, current WS support. Code base is roughly 9k LOC.</blockquote><div><br></div><div>Completeness shouldn't really be measured by size of code base. I take your point that the latest version of the protocol is indeed supported in Autobahn, which is a good thing of course.</div>
<div><br></div><div>Thanks for Autobahn - it's useful to take a look at. I'll still continue work on txWebsocket, however, with the intention of:</div><div><br></div><div>* eventual inclusion into Twisted (meeting Twisted coding standards, MIT license, etc.)</div>
<div>* small, simple code base</div><div><br></div><div>Hopefully one day if and when txWebSocket is finally merged we can standardize on one reference implementation (it doesn't have to be txWebsocket of course - it'd be great if the core of Autobahn could be contributed...)</div>
<div><br></div><div>Thanks,</div><div>Reza</div><div><br></div></div>-- <br>Reza Lotun<br>mobile: +44 (0)7521 310 763<br>email: <a href="mailto:rlotun@gmail.com" target="_blank">rlotun@gmail.com</a><br>work: <a href="mailto:rlotun@twitter.com" target="_blank">rlotun@twitter.com</a><br>
@rlotun<br><br>
</div>