[Twisted-Python] non-merge commits to trunk & "review" keyword

[Craig Rodrigues]

On Mon, Mar 6, 2017 at 8:37 PM, Glyph Lefkowitz <glyph at twistedmatrix.com>
wrote:

>
>
> Craig, since you're the one who made this merge, can you explain what
> happened?  Has github's 'merge' button stopped prompting for a commit
> message?  Failing to wait for the removal of the 'review' keyword was
> obviously a mistake, but based on my previous experience with the 'merge'
> button this wouldn't even be a type of mistake that's _possible_ to make;
> understanding what you did to trigger it would therefore be very useful.
>
>
Woops, sorry about that.  I pressed the Merge button in git, but I guess I
clicked on the wrong
option after that.  It is good that this is now disabled to prevent future
mistakes like this.

--
Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20170307/bc56ce6b/attachment-0002.html>