[Twisted-Python] non-merge commits to trunk & "review" keyword

[Glyph Lefkowitz]

> On Mar 7, 2017, at 10:40 AM, Craig Rodrigues <rodrigc at crodrigues.org> wrote:
> 
> 
> 
> On Mon, Mar 6, 2017 at 8:37 PM, Glyph Lefkowitz <glyph at twistedmatrix.com <mailto:glyph at twistedmatrix.com>> wrote:
> 
> 
> Craig, since you're the one who made this merge, can you explain what happened?  Has github's 'merge' button stopped prompting for a commit message?  Failing to wait for the removal of the 'review' keyword was obviously a mistake, but based on my previous experience with the 'merge' button this wouldn't even be a type of mistake that's _possible_ to make; understanding what you did to trigger it would therefore be very useful.
> 
> 
> Woops, sorry about that.  I pressed the Merge button in git, but I guess I clicked on the wrong
> option after that.  It is good that this is now disabled to prevent future mistakes like this.

OK, good to know; so this was a repo misconfiguration coupled with human error.  Glad we have something in place to prevent it now :).

Craig - that said, can you go back and fix up the relevant state (kill the 'review' keyword, close the ticket with a reference to the relevant commit, and so on)?

-glyph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20170307/24cef158/attachment-0002.html>